Skip to content

build: use BC signer - #1082

Merged
gotson merged 1 commit into
xerial:masterfrom
cstamas:gpg-bc
Mar 12, 2024
Merged

gotson merged 1 commit into
xerial:masterfrom
cstamas:gpg-bc

Conversation

@cstamas

@cstamas cstamas commented Mar 12, 2024 •

Copy link
Copy Markdown
Contributor

Changes:

  • upgrade to 3.2.0 GPG plugin
  • do NOT import key in home of runner (and leave it there once job done?)
  • instead, make them both env variables
  • and on CI force BC signer

This leaves GPG on workstation work unchanged.

Related to https://issues.apache.org/jira/browse/MGPG-90

Changes:
* upgrade to 3.2.0 GPG plugin
* do NOT store key in home of runner,
* instead, make them both env variables
* and on CI force BC signer

This leaves GPG on workstation work unchanged.
@gotson

gotson commented Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Thanks a lot @cstamas for the PR, let me merge this and see if the deploy works fine for snapshots!

@gotson gotson changed the title Stay away from setup-java and use BC signer build: use BC signer Mar 12, 2024
@gotson
gotson merged commit c84d122 into xerial:master Mar 12, 2024
@gotson

gotson commented Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Seems like it worked alright, thanks again @cstamas !

@cstamas
cstamas deleted the gpg-bc branch March 12, 2024 09:42
galtm added a commit to galtm/xspec that referenced this pull request Mar 14, 2024
Maven deployment broke when xspec repo bumped
maven-gpg-plugin from 3.1.0 to 3.2.0 (xspec#1874).

This change imitates the fix in another repo that had
the "gpg: signing failed: No pinentry" error with that
version of the plugin.

References:
* https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/examples/deploy-signed-artifacts.html#sign-using-bc-signer
* https://issues.apache.org/jira/projects/MGPG/issues/MGPG-90?filter=allopenissues (see comments in 3/2024)
* Example, xerial/sqlite-jdbc#1082
galtm added a commit to xspec/xspec that referenced this pull request Mar 18, 2024
Maven deployment broke when xspec repo bumped
maven-gpg-plugin from 3.1.0 to 3.2.0 (#1874).

This change imitates the fix in another repo that had
the "gpg: signing failed: No pinentry" error with that
version of the plugin.

References:
* https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/examples/deploy-signed-artifacts.html#sign-using-bc-signer
* https://issues.apache.org/jira/projects/MGPG/issues/MGPG-90?filter=allopenissues (see comments in 3/2024)
* Example, xerial/sqlite-jdbc#1082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants