Repository navigation
build: use BC signer - #1082
Merged
Merged
build: use BC signer#1082
Conversation
Changes: * upgrade to 3.2.0 GPG plugin * do NOT store key in home of runner, * instead, make them both env variables * and on CI force BC signer This leaves GPG on workstation work unchanged.
Collaborator
|
Thanks a lot @cstamas for the PR, let me merge this and see if the deploy works fine for snapshots! |
Collaborator
|
Seems like it worked alright, thanks again @cstamas ! |
galtm
added a commit
to galtm/xspec
that referenced
this pull request
Mar 14, 2024
Maven deployment broke when xspec repo bumped maven-gpg-plugin from 3.1.0 to 3.2.0 (xspec#1874). This change imitates the fix in another repo that had the "gpg: signing failed: No pinentry" error with that version of the plugin. References: * https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/examples/deploy-signed-artifacts.html#sign-using-bc-signer * https://issues.apache.org/jira/projects/MGPG/issues/MGPG-90?filter=allopenissues (see comments in 3/2024) * Example, xerial/sqlite-jdbc#1082
galtm
added a commit
to xspec/xspec
that referenced
this pull request
Mar 18, 2024
Maven deployment broke when xspec repo bumped maven-gpg-plugin from 3.1.0 to 3.2.0 (#1874). This change imitates the fix in another repo that had the "gpg: signing failed: No pinentry" error with that version of the plugin. References: * https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/examples/deploy-signed-artifacts.html#sign-using-bc-signer * https://issues.apache.org/jira/projects/MGPG/issues/MGPG-90?filter=allopenissues (see comments in 3/2024) * Example, xerial/sqlite-jdbc#1082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This leaves GPG on workstation work unchanged.
Related to https://issues.apache.org/jira/browse/MGPG-90